mixer function RC: output disarmed value with no valid RC input #23213
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
I received the report from @fury1895 that when:
COM_PREARM_MODE
the servo goes to the center position instead of the configured disarmed position.
Solution
I agree that this is unexpected and suggest that actuators mapped to and RC input directly get commanded their disarmed output whenever the RC input is not available (anymore).
Changelog Entry
Alternatives
We could keep the last valid RC input instead but it's not only more complicated I also currently don't exactly see what use case would require this behavior.
Test coverage
This was not tested. Please @fury1895 test and give feedback.